-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization breadcrumb data of ActiveSupportLogger #2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @igordepolli!
one small change then good to go
sentry-rails/lib/sentry/rails/breadcrumb/active_support_logger.rb
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
===========================================
- Coverage 97.27% 59.69% -37.58%
===========================================
Files 97 86 -11
Lines 3630 3389 -241
===========================================
- Hits 3531 2023 -1508
- Misses 99 1366 +1267
|
@sl0thentr0py Done. Ty for review :) |
sentry-rails/spec/sentry/rails/breadcrumbs/active_support_logger_spec.rb
Outdated
Show resolved
Hide resolved
@st0012 Done. Good catch! Ty! :) |
@igordepolli the https://github.com/getsentry/sentry-ruby/actions/runs/6620176438/job/17999733560?pr=2139#step:5:156 You can also just give me push rights to the PR and I'll take care of the rest and merge this in. |
@sl0thentr0py Oh, sorry for the inconvenience. You already have the right to manipulate PR however you want, feel free. |
Ref: #2135
Description
Add new
config.rails.active_support_logger_subscription_items
to allow customization breadcrumb data of active support logger